correct to_finite

This fixes issue #596.

* spot/twaalgos/remprop.cc: Rewrite main loop.
* tests/core/ltlf.test: Add test case.
* tests/python/game.py: Remove a test that appears
to make incorrect assumptions about to_finite.
* NEWS: Mention the bug.

tests/core/ltlf.test

@@ -173,51 +173,62 @@ cmp out3 out4 && exit 1 # make sure we did remove something
 autfilt out3 > out4
 diff out4 expected3
 
-# Issue #526
-ltlfilt -f '(i->XXo)|G(i<->Xo2)' --from-ltlf | ltl2tgba -D |\
+# Issue #526 and Issue #596
+ltlfilt -f '(i->XXo)|G(i<->Xo2)' -f XXXo --from-ltlf | ltl2tgba -D |\
     autfilt -C --to-finite > out
 cat >exp <<EOF
 HOA: v1
-States: 9
+States: 8
 Start: 0
 AP: 3 "o" "o2" "i"
 acc-name: Buchi
 Acceptance: 1 Inf(0)
-properties: trans-labels explicit-labels state-acc complete
-properties: deterministic
+properties: trans-labels explicit-labels state-acc deterministic
 --BODY--
-State: 0 {0}
+State: 0
 [2] 6
 [!2] 7
 State: 1
 [!1&!2] 1
 [!1&2] 5
-[1] 8
 State: 2 {0}
 [0] 7
-[!0] 8
 State: 3 {0}
 [!0&!1&!2] 1
 [!0&!1&2] 5
 [0] 7
-[!0&1] 8
 State: 4 {0}
 [!0&1&!2] 1
 [!0&1&2] 5
 [0] 7
-[!0&!1] 8
 State: 5 {0}
 [1&!2] 1
 [1&2] 5
-[!1] 8
 State: 6 {0}
 [!1] 2
 [1&!2] 3
 [1&2] 4
 State: 7 {0}
 [t] 7
-State: 8
-[t] 8
+--END--
+HOA: v1
+States: 5
+Start: 0
+AP: 1 "o"
+acc-name: Buchi
+Acceptance: 1 Inf(0)
+properties: trans-labels explicit-labels state-acc deterministic
+--BODY--
+State: 0
+[t] 4
+State: 1 {0}
+[0] 3
+State: 2 {0}
+[t] 1
+State: 3 {0}
+[t] 3
+State: 4 {0}
+[t] 2
 --END--
 EOF
 diff out exp