From abe722297306c75ee1b2521e5dbc7a32a83d5df0 Mon Sep 17 00:00:00 2001
From: Alexandre Duret-Lutz <adl@lrde.epita.fr>
Date: Fri, 12 May 2023 11:32:46 +0200
Subject: [PATCH] bitvect: work around incorrect warning from gcc

* spot/misc/bitvect.hh: Don't free the old ptr if realloc() returns
NULL, as this confuse GCC who warns that we are freeing something that
has already been freed.   Instead, let the ~bitvect() destructor
handle this.
---
 spot/misc/bitvect.hh | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/spot/misc/bitvect.hh b/spot/misc/bitvect.hh
index 3588b406e..74ab2bf3f 100644
--- a/spot/misc/bitvect.hh
+++ b/spot/misc/bitvect.hh
@@ -1,5 +1,5 @@
 // -*- coding: utf-8 -*-
-// Copyright (C) 2013-2021 Laboratoire de Recherche et Développement
+// Copyright (C) 2013-2021, 2023 Laboratoire de Recherche et Développement
 // de l'Epita (LRDE).
 //
 // This file is part of Spot, a model checking library.
@@ -111,22 +111,22 @@ namespace spot
         return;
       if (storage_ == &local_storage_)
         {
-          block_t* new_storage_ = static_cast<block_t*>
+          block_t* new_storage = static_cast<block_t*>
             (malloc(new_block_count * sizeof(block_t)));
+          if (SPOT_UNLIKELY(!new_storage))
+            throw std::bad_alloc();
           for (size_t i = 0; i < block_count_; ++i)
-            new_storage_[i] = storage_[i];
-          storage_ = new_storage_;
+            new_storage[i] = storage_[i];
+          storage_ = new_storage;
         }
       else
         {
-          auto old = storage_;
-          storage_ = static_cast<block_t*>
-            (realloc(old, new_block_count * sizeof(block_t)));
-          if (!storage_)
-            {
-              free(old);
-              throw std::bad_alloc();
-            }
+          block_t* new_storage = static_cast<block_t*>
+            (realloc(storage_, new_block_count * sizeof(block_t)));
+          if (SPOT_UNLIKELY(!new_storage))
+            // storage_, untouched, will be freed by the destructor.
+            throw std::bad_alloc();
+          storage_ = new_storage;
         }
       block_count_ = new_block_count;
     }
@@ -134,8 +134,8 @@ namespace spot
   private:
     void grow()
     {
-      size_t new_block_count_ = (block_count_ + 1) * 7 / 5;
-      reserve_blocks(new_block_count_);
+      size_t new_block_count = (block_count_ + 1) * 7 / 5;
+      reserve_blocks(new_block_count);
     }
 
   public: