From ef9267a58ef71659c37f94c2c7458c84c51bb195 Mon Sep 17 00:00:00 2001 From: Alexandre Duret-Lutz Date: Fri, 6 May 2022 13:58:52 +0200 Subject: [PATCH] parsetl: remove a superfluous diagnostic on some erroneous input * tests/core/neverclaimread.test: Adjust and remove FIXME. * spot/parsetl/parsetl.yy (try_recursive_parse): Return false on empty string. --- spot/parsetl/parsetl.yy | 2 +- tests/core/neverclaimread.test | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/spot/parsetl/parsetl.yy b/spot/parsetl/parsetl.yy index e6defffb3..117695404 100644 --- a/spot/parsetl/parsetl.yy +++ b/spot/parsetl/parsetl.yy @@ -296,7 +296,7 @@ using namespace spot; if (str.empty()) { error_list.emplace_back(location, "unexpected empty block"); - return nullptr; + return fnode::ff(); } spot::parsed_formula pf; diff --git a/tests/core/neverclaimread.test b/tests/core/neverclaimread.test index bf736f55d..09af8af58 100755 --- a/tests/core/neverclaimread.test +++ b/tests/core/neverclaimread.test @@ -350,10 +350,8 @@ digraph "-" { } EOF diff stdout expected -# FIXME: the "ignoring trailing garbage" is unwanted cat >expected.err <