alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

When iterating a hash_map, be careful not to delete i->first

Browse source 
before doing ++i to avoid memory issues.

* src/tgba/taatgba.cc, src/tgba/taatgba.hh,
src/tgba/tgbaexplicit.cc, src/tgba/tgbaexplicit.hh: Fix them.
This commit is contained in:
Damien Lefortier 2010-01-20 17:37:25 +01:00
parent 0d6fd3225a
commit 04827ef4a1
5 changed files with 63 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/tgba/taatgba.hh
View file

@ -159,18 +159,6 @@ namespace spot
public:
taa_tgba_labelled(bdd_dict* dict) : taa_tgba(dict) {};
virtual ~taa_tgba_labelled()
{
typename ns_map::iterator i;
for (i = name_state_map_.begin(); i != name_state_map_.end(); ++i)
{
taa_tgba::state::iterator i2;
for (i2 = i->second->begin(); i2 != i->second->end(); ++i2)
delete *i2;
delete i->second;
}
}
void set_init_state(const label& s)
{
std::vector<label> v(1);
@ -344,6 +332,7 @@ namespace spot
public:
taa_tgba_string(bdd_dict* dict) :
taa_tgba_labelled<std::string, string_hash>(dict) {};
~taa_tgba_string();
protected:
virtual std::string label_to_string(const std::string& label) const;
virtual std::string clone_if(const std::string& label) const;
@ -355,7 +344,6 @@ namespace spot
public:
taa_tgba_formula(bdd_dict* dict) :
taa_tgba_labelled<const ltl::formula*, ltl::formula_ptr_hash>(dict) {};
// Labels are pointers here and must be destroyed eventually.
~taa_tgba_formula();
protected:
virtual std::string label_to_string(const label_t& label) const;