alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

more code smells

Browse source 
* bin/common_file.cc, bin/common_file.hh, bin/common_finput.cc,
bin/common_finput.hh, bin/common_output.cc, bin/common_setup.cc,
bin/common_setup.hh, bin/common_trans.cc, bin/common_trans.hh,
bin/dstar2tgba.cc, bin/genaut.cc, bin/genltl.cc, bin/ltl2tgba.cc,
bin/ltl2tgta.cc, bin/ltlcross.cc, bin/ltldo.cc, bin/ltlfilt.cc,
bin/ltlsynt.cc, bin/randltl.cc: Fix minor code issues reported by
sonarcloud.
This commit is contained in:
Alexandre Duret-Lutz 2023-01-06 11:55:34 +01:00
parent 96c3972c5c
commit 09bbaa1e41
19 changed files with 133 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

13
bin/common_file.hh
View file

@ -1,6 +1,6 @@
// -*- coding: utf-8 -*-
// Copyright (C) 2015, 2016, 2022 Laboratoire de Recherche et Développement de
// l'Epita (LRDE).
// Copyright (C) 2015-2016, 2022-2023 Laboratoire de Recherche et
// Développement de l'Epita (LRDE).
//
// This file is part of Spot, a model checking library.
//
@ -21,13 +21,13 @@
#include "common_sys.hh"
#include <iosfwd>
#include <memory>
#include <fstream>
#include <error.h>
class output_file
{
std::ostream* os_;
std::ofstream* of_ = nullptr;
std::unique_ptr<std::ofstream> of_;
bool append_ = false;
public:
// Open a file for output. "-" is interpreted as stdout.
@ -37,11 +37,6 @@ public:
void close(const std::string& name);
~output_file()
{
delete of_;
}
bool append() const
{
return append_;