alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

more code smells

Browse source 
* bin/common_file.cc, bin/common_file.hh, bin/common_finput.cc,
bin/common_finput.hh, bin/common_output.cc, bin/common_setup.cc,
bin/common_setup.hh, bin/common_trans.cc, bin/common_trans.hh,
bin/dstar2tgba.cc, bin/genaut.cc, bin/genltl.cc, bin/ltl2tgba.cc,
bin/ltl2tgta.cc, bin/ltlcross.cc, bin/ltldo.cc, bin/ltlfilt.cc,
bin/ltlsynt.cc, bin/randltl.cc: Fix minor code issues reported by
sonarcloud.
This commit is contained in:
Alexandre Duret-Lutz 2023-01-06 11:55:34 +01:00
parent 96c3972c5c
commit 09bbaa1e41
19 changed files with 133 additions and 178 deletions
Download patch file Download diff file Expand all files Collapse all files

19
bin/common_trans.hh
View file

@ -51,7 +51,8 @@ struct tool_spec
// Whether the tool is a reference.
bool reference;
tool_spec(const char* spec, shorthands_t* begin, shorthands_t* end,
tool_spec(const char* spec,
const shorthands_t* begin, const shorthands_t* end,
bool is_ref) noexcept;
tool_spec(const tool_spec& other) noexcept;
tool_spec& operator=(const tool_spec& other);
@ -71,7 +72,7 @@ struct quoted_formula final: public spot::printable_value<spot::formula>
struct filed_formula final: public spot::printable
{
filed_formula(const quoted_formula& ltl) : f_(ltl)
explicit filed_formula(const quoted_formula& ltl) : f_(ltl)
{
}
@ -89,9 +90,7 @@ struct filed_formula final: public spot::printable
struct filed_automaton final: public spot::printable
{
filed_automaton()
{
}
filed_automaton() = default;
void print(std::ostream& os, const char* pos) const override;
@ -112,7 +111,7 @@ struct printable_result_filename final:
unsigned translator_num;
printable_result_filename();
~printable_result_filename();
~printable_result_filename() override;
void reset(unsigned n);
void cleanup();
@ -126,7 +125,7 @@ protected:
spot::bdd_dict_ptr dict;
// Round-specific variables
quoted_formula ltl_formula;
filed_formula filename_formula = ltl_formula;
filed_formula filename_formula{ltl_formula};
// Run-specific variables
printable_result_filename output;
public:
@ -151,9 +150,9 @@ protected:
public:
using spot::formater::has;
autproc_runner(// whether we accept the absence of output
// specifier
bool no_output_allowed = false);
explicit autproc_runner(// whether we accept the absence of output
// specifier
bool no_output_allowed = false);
void round_automaton(spot::const_twa_graph_ptr aut, unsigned serial);
};