alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

bin: fix number conversion routines on 32bit

Browse source 
On 32bit archetectures, long int = int the current check for detecting
values that overflow int will fail.  Conversion routings should check
errno.

* bin/common_conv.cc, bin/common_range.cc: Here.
This commit is contained in:
Alexandre Duret-Lutz 2023-01-24 15:48:06 +01:00
parent a1c02856ac
commit 126d9bc103
2 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
bin/common_range.cc
View file

@ -36,9 +36,10 @@ parse_range(const char* str, int missing_left, int missing_right)
{
range res;
char* end;
errno = 0;
long lres = strtol(str, &end, 10);
res.min = lres;
if (res.min != lres)
if (res.min != lres || errno == ERANGE)
error(2, 0, "start of range '%s' is too large for an int.", str);
if (end == str)
{
@ -69,9 +70,10 @@ parse_range(const char* str, int missing_left, int missing_right)
{
// Parse the next integer.
char* end2;
errno = 0;
lres = strtol(end, &end2, 10);
res.max = lres;
if (res.max != lres)
if (res.max != lres || errno == ERANGE)
error(2, 0, "end of range '%s' is too large for an int.", str);
if (str == end2)
error(2, 0, "invalid range '%s' "