alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

never iterate on the edge_vector()

Browse source 
This fixes #552, reported by Rüdiger and Ayrat.

* tests/sanity/style.test: Warn aginst iterations on edge_vector.
* spot/parseaut/parseaut.yy, spot/twaalgos/complete.cc,
spot/twaalgos/parity.cc: Iterate over edges(), not edge_vector().
* tests/core/ltlcross.test: Add a test case for #552.
* NEWS: Mention the bug.
This commit is contained in:
Alexandre Duret-Lutz 2023-11-17 22:07:40 +01:00
parent 313e43c84b
commit 205df01390
6 changed files with 27 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
spot/parseaut/parseaut.yy
View file

@ -2556,7 +2556,7 @@ static void fix_acceptance(result_& r)
auto onlyneg = r.neg_acc_sets - r.pos_acc_sets;
if (onlyneg)
{
for (auto& t: r.h->aut->edge_vector())
for (auto& t: r.h->aut->edges())
t.acc ^= onlyneg;
}
@ -2570,7 +2570,7 @@ static void fix_acceptance(result_& r)
if (both)
{
base = acc.add_sets(both.count());
for (auto& t: r.h->aut->edge_vector())
for (auto& t: r.h->aut->edges())
{
unsigned i = 0;
if ((t.acc & both) != both)

2
spot/twaalgos/complete.cc
View file

@ -144,7 +144,7 @@ namespace spot
if (need_acc_fix)
{
auto a = aut->set_buchi();
for (auto& t: aut->edge_vector())
for (auto& t: aut->edges())
t.acc = a;
if (aut->num_edges())
acc = a;

2
spot/twaalgos/parity.cc
View file

@ -50,7 +50,7 @@ namespace spot
change_acc(twa_graph_ptr& aut, unsigned num_sets, bool change_kind,
bool change_style, bool output_max, bool input_max)
{
for (auto& e: aut->edge_vector())
for (auto& e: aut->edges())
if (e.acc)
{
unsigned msb = (input_max ? e.acc.max_set() : e.acc.min_set()) - 1;