alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

taproduct: fix incorrect assert() flagged by PVS-Studio

Browse source 
For #192.

* spot/ta/taproduct.cc: Check the output of down_cast, not its input.
This commit is contained in:
Alexandre Duret-Lutz 2016-10-28 22:43:54 +02:00
parent d0112a7b8a
commit 26e94b774f
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spot/ta/taproduct.cc
View file

@ -297,9 +297,8 @@ namespace spot
ta_succ_iterator_product* ta_succ_iterator_product*
ta_product::succ_iter(const state* s) const ta_product::succ_iter(const state* s) const
{ {
const state_ta_product* stp = down_cast<const state_ta_product*> (s); const state_ta_product* stp = down_cast<const state_ta_product*>(s);
assert(s); assert(stp);
return new ta_succ_iterator_product(stp, ta_.get(), kripke_.get()); return new ta_succ_iterator_product(stp, ta_.get(), kripke_.get());
} }
@ -307,8 +306,8 @@ namespace spot
ta_succ_iterator_product* ta_succ_iterator_product*
ta_product::succ_iter(const spot::state* s, bdd changeset) const ta_product::succ_iter(const spot::state* s, bdd changeset) const
{ {
const state_ta_product* stp = down_cast<const state_ta_product*> (s); const state_ta_product* stp = down_cast<const state_ta_product*>(s);
assert(s); assert(stp);
return new ta_succ_iterator_product_by_changeset(stp, return new ta_succ_iterator_product_by_changeset(stp,
ta_.get(), kripke_.get(), ta_.get(), kripke_.get(),
changeset); changeset);