common: introduce SPOT_UNREACHABLE and SPOT_UNIMPLEMENTED.

* src/misc/common.hh (SPOT_UNIMPLEMENTED, SPOT_UNREACHABLE,
SPOT_UNREACHABLE_BUILTIN): New macros.
* src/bin/dstar2tgba.cc, src/bin/ltlcross.cc,
src/dstarparse/dstar2tgba.cc, src/eltlparse/eltlparse.yy,
src/ltlast/binop.cc, src/ltlast/bunop.cc, src/ltlast/constant.cc,
src/ltlast/formula_tree.cc, src/ltlast/multop.cc, src/ltlast/nfa.cc,
src/ltlast/unop.cc, src/ltlvisit/dotty.cc, src/ltlvisit/lbt.cc,
src/ltlvisit/lunabbrev.cc, src/ltlvisit/mark.cc,
src/ltlvisit/randomltl.cc, src/ltlvisit/simpfg.cc,
src/ltlvisit/simplify.cc, src/ltlvisit/snf.cc, src/ltlvisit/tostring.cc,
src/misc/intvcomp.cc, src/misc/minato.cc, src/tgba/bdddict.cc,
src/tgba/formula2bdd.cc, src/tgba/tgbasafracomplement.cc,
src/tgbaalgos/eltl2tgba_lacim.cc, src/tgbaalgos/ltl2taa.cc,
src/tgbaalgos/ltl2tgba_fm.cc, src/tgbaalgos/ltl2tgba_lacim.cc,
src/tgbaalgos/simulation.cc, src/tgbatest/ltl2tgba.cc:  Use them.
* src/sanity/style.test: Catch assert(0) and assert(!"text");
This commit is contained in:
Alexandre Duret-Lutz 2014-06-27 14:42:54 +02:00
parent c93b41a2c7
commit 2beacc3924
33 changed files with 190 additions and 227 deletions

View file

@ -185,7 +185,7 @@ namespace spot
else if (f == constant::false_instance())
result = bddfalse;
else
assert(!"Unsupported operator");
SPOT_UNIMPLEMENTED();
break;
case formula::AtomicProp:
result = bdd_ithvar(dict->register_proposition(f, this));
@ -213,7 +213,7 @@ namespace spot
op = bddop_biimp;
break;
default:
assert(!"Unsupported operator");
SPOT_UNIMPLEMENTED();
}
result = bdd_apply(as_bdd(bo->first()), as_bdd(bo->second()), op);
break;
@ -244,14 +244,14 @@ namespace spot
case multop::OrRat:
case multop::Concat:
case multop::Fusion:
assert(!"Unsupported operator");
SPOT_UNIMPLEMENTED();
break;
}
break;
}
case formula::BUnOp:
case formula::AutomatOp:
assert(!"Unsupported operator");
SPOT_UNIMPLEMENTED();
break;
}
@ -490,9 +490,7 @@ namespace spot
{
case unop::Not:
// "Not"s should be caught by nenoform_recursively().
assert(!"Not should not occur");
//result_ = recurse_(f, negated_ ^ true);
return;
SPOT_UNREACHABLE();
case unop::X:
/* !Xa == X!a */
result_ = unop::instance(unop::X, recurse(f));
@ -525,8 +523,7 @@ namespace spot
result_ = unop::instance(unop::Not, result_);
return;
}
/* Unreachable code. */
assert(0);
SPOT_UNREACHABLE();
}
void
@ -630,8 +627,7 @@ namespace spot
recurse_(f1, false), recurse(f2));
return;
}
// Unreachable code.
assert(0);
SPOT_UNREACHABLE();
}
void
@ -2182,7 +2178,7 @@ namespace spot
case binop::Xor:
case binop::Equiv:
case binop::Implies:
assert(!"operator not supported for implication rules");
SPOT_UNIMPLEMENTED();
return;
case binop::UConcat:
case binop::EConcat: