always capture exceptions by const references

For #199.

* tests/sanity/style.test: Test this.
* bin/ltlcross.cc, spot/parseaut/parseaut.yy,
tests/ltsmin/modelcheck.cc: Fix it.

tests/ltsmin/modelcheck.cc

@@ -222,7 +222,7 @@ checked_main(int argc, char **argv)
           model = spot::ltsmin_model::load(argv[1]).kripke(&ap, dict, deadf,
                                                            compress_states);
         }
-      catch (std::runtime_error& e)
+      catch (const std::runtime_error& e)
         {
           std::cerr << e.what() << '\n';
         }

tests/sanity/style.test

@@ -287,6 +287,10 @@ for dir in "$TOP/spot" "$TOP/bin" "$TOP/tests"; do
 	 diag 'No "if (x)" required before "delete x;".'
       fi
 
+      # we want catch (const reftype&) or catch (...)
+      $GREP 'catch *([^.]' $tmp | $GREP -v 'const.*\&' &&
+	diag 'Always capture exceptions by const reference.'
+
       case $file in
 	*.hh | *.hxx)
 	  if e$GREP '(<<|>>)' $tmp >/dev/null; then