bin: handle thousands of output files
Fixes #534. * bin/common_file.hh, bin/common_file.cc: Make it possible to reopen a closed file. * bin/common_output.cc, bin/common_aoutput.cc: Add a heuristic to decide when to close files. * tests/core/serial.test: Add a test case. * NEWS: Mention the issue.
This commit is contained in:
parent
17a5b41d8c
commit
40e30df7e3
6 changed files with 76 additions and 1 deletions
|
|
@ -44,13 +44,30 @@ output_file::output_file(const char* name, bool force_append)
|
|||
os_ = of_.get();
|
||||
}
|
||||
|
||||
void
|
||||
output_file::reopen_for_append(const std::string& name)
|
||||
{
|
||||
if (of_ && of_->is_open()) // nothing to do
|
||||
return;
|
||||
const char* cname = name.c_str();
|
||||
if (cname[0] == '>' && cname[1] == '>')
|
||||
cname += 2;
|
||||
if (name[0] == '-' && name[1] == 0)
|
||||
{
|
||||
os_ = &std::cout;
|
||||
return;
|
||||
}
|
||||
of_->open(cname, std::ios_base::app);
|
||||
if (!*of_)
|
||||
error(2, errno, "cannot reopen '%s'", cname);
|
||||
}
|
||||
|
||||
void output_file::close(const std::string& name)
|
||||
{
|
||||
// We close of_, not os_, so that we never close std::cout.
|
||||
if (os_)
|
||||
os_->flush();
|
||||
if (of_)
|
||||
if (of_ && of_->is_open())
|
||||
of_->close();
|
||||
if (os_ && !*os_)
|
||||
error(2, 0, "error writing to %s",
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue