alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

use more override and final keywords

Browse source 
This patch is mostly focused on tagging most virtual methods that
override as such.  I found a few methods that where not meant to be
virtual this way, and tagged a few classes "final" along the way.

* bin/common_output.cc, spot/kripke/fairkripke.hh,
spot/kripke/kripke.hh, spot/kripke/kripkegraph.hh,
spot/ltsmin/ltsmin.cc, spot/misc/formater.hh, spot/priv/bddalloc.hh,
spot/ta/ta.hh, spot/ta/taexplicit.hh, spot/ta/taproduct.hh,
spot/ta/tgta.hh, spot/ta/tgtaexplicit.cc, spot/ta/tgtaexplicit.hh,
spot/ta/tgtaproduct.hh, spot/taalgos/emptinessta.hh, spot/tl/declenv.hh,
spot/tl/defaultenv.hh, spot/tl/randomltl.hh, spot/tl/relabel.cc,
spot/twa/bdddict.cc, spot/twa/taatgba.hh, spot/twa/twagraph.hh,
spot/twa/twaproduct.hh, spot/twaalgos/gtec/ce.cc,
spot/twaalgos/gtec/ce.hh, spot/twaalgos/gtec/gtec.hh,
spot/twaalgos/gv04.cc, spot/twaalgos/ltl2taa.cc, spot/twaalgos/magic.cc,
spot/twaalgos/minimize.cc, spot/twaalgos/ndfs_result.hxx,
spot/twaalgos/reachiter.hh, spot/twaalgos/se05.cc,
spot/twaalgos/stutter.cc, spot/twaalgos/tau03.cc: Add more override and
final keywords.
This commit is contained in:
Alexandre Duret-Lutz 2016-02-15 22:43:23 +01:00
parent 1ae0600cae
commit 5d272fd256
35 changed files with 249 additions and 291 deletions
Download patch file Download diff file Expand all files Collapse all files

36
spot/ltsmin/ltsmin.cc
View file

@ -258,7 +258,7 @@ namespace spot
////////////////////////////////////////////////////////////////////////
// SUCC_ITERATOR
class spins_succ_iterator: public kripke_succ_iterator
class spins_succ_iterator final: public kripke_succ_iterator
{
public:
@ -280,28 +280,24 @@ namespace spot
delete cc_;
}
virtual
bool first()
virtual bool first() override
{
it_ = cc_->transitions.begin();
return it_ != cc_->transitions.end();
}
virtual
bool next()
virtual bool next() override
{
++it_;
return it_ != cc_->transitions.end();
}
virtual
bool done() const
virtual bool done() const override
{
return it_ == cc_->transitions.end();
}
virtual
state* dst() const
virtual state* dst() const override
{
return (*it_)->clone();
}
@ -605,7 +601,7 @@ namespace spot
////////////////////////////////////////////////////////////////////////
// KRIPKE
class spins_kripke: public kripke
class spins_kripke final: public kripke
{
public:
@ -615,7 +611,7 @@ namespace spot
: kripke(dict),
d_(d),
state_size_(d_->get_state_size()),
dict_(dict), ps_(ps),
ps_(ps),
compress_(compress == 0 ? nullptr
: compress == 1 ? int_array_array_compress
: int_array_array_compress2),
@ -696,8 +692,7 @@ namespace spot
delete state_condition_last_cc_; // Might be 0 already.
}
virtual
state* get_init_state() const
virtual state* get_init_state() const override
{
if (compress_)
{
@ -848,8 +843,7 @@ namespace spot
virtual
spins_succ_iterator*
succ_iter(const state* st) const
spins_succ_iterator* succ_iter(const state* st) const override
{
// This may also compute successors in state_condition_last_cc
bdd scond = compute_state_condition(st);
@ -882,14 +876,13 @@ namespace spot
}
virtual
bdd
state_condition(const state* st) const
bdd state_condition(const state* st) const override
{
return compute_state_condition(st);
}
virtual
std::string format_state(const state *st) const
std::string format_state(const state *st) const override
{
const int* vars = get_vars(st);
@ -917,16 +910,9 @@ namespace spot
return res.str();
}
virtual
spot::bdd_dict_ptr get_dict() const
{
return dict_;
}
private:
spins_interface_ptr d_;
int state_size_;
bdd_dict_ptr dict_;
const char** vname_;
bool* format_filter_;
const spot::prop_set* ps_;