Fix errors reported by ICC.

* src/tgba/state.hh (state_ptr_less_than::operator()): Make it const.
* src/tgba/tgbaproduct.cc: Include string.hh.
* src/ltlast/multop.hh (multop::add, multop::add_sorted): Do
not use qualified names in declarations.
* m4/gccwarn.m4 (CF_GXX_WARNINGS): Fix GXX test.
* src/ltlenv/defaultenv.hh, src/ltlenv/defaultenv.cc,
src/ltlenv/environment.hh: Add virtual destructors.

ChangeLog

@@ -1,3 +1,15 @@
+2003-06-28  Alexandre Duret-Lutz  <aduret@src.lip6.fr>
+
+	Fix errors reported by ICC.
+
+	* src/tgba/state.hh (state_ptr_less_than::operator()): Make it const.
+	* src/tgba/tgbaproduct.cc: Include string.hh.
+	* src/ltlast/multop.hh (multop::add, multop::add_sorted): Do
+	not use qualified names in declarations.
+	* m4/gccwarn.m4 (CF_GXX_WARNINGS): Fix GXX test.
+	* src/ltlenv/defaultenv.hh, src/ltlenv/defaultenv.cc,
+	src/ltlenv/environment.hh: Add virtual destructors.
+
 2003-06-26  Alexandre Duret-Lutz  <aduret@src.lip6.fr>
 
 	* Makefile.am (EXTRA_DIST): Add HACKING.

m4/gccwarn.m4

@@ -14,7 +14,7 @@ dnl A few other options have been left out because they are annoying in C++.
 
 
 AC_DEFUN([CF_GXX_WARNINGS],
-[if test -n "$GXX"; then
+[if test "x$GXX" = xyes; then
   AC_CACHE_CHECK([for g++ warning options], ac_cv_prog_gxx_warn_flags,
   [
   cat > conftest.$ac_ext <<EOF

src/ltlast/multop.hh

@@ -86,8 +86,8 @@ namespace spot
 
       multop(type op, vec* v);
       static multop* instance(type op, vec* v);
-      static vec* multop::add(type op, vec* v, formula* f);
-      static void multop::add_sorted(vec* v, formula* f);
+      static vec* add(type op, vec* v, formula* f);
+      static void add_sorted(vec* v, formula* f);
 
       virtual ~multop();
 

src/ltlenv/defaultenv.cc

@@ -6,6 +6,10 @@ namespace spot
   namespace ltl
   {
 
+    default_environment::~default_environment()
+    {
+    }
+
     formula*
     default_environment::require(const std::string& s)
     {

src/ltlenv/defaultenv.hh

@@ -17,6 +17,7 @@ namespace spot
     class default_environment : public environment
     {
     public:
+      virtual ~default_environment();
       virtual formula* require(const std::string& prop_str);
       virtual const std::string& name();
 

src/ltlenv/environment.hh

@@ -35,6 +35,11 @@ namespace spot
       /// Get the name of the environment.
       virtual const std::string& name() = 0;
 
+      virtual
+      ~environment()
+      {
+      };
+
       // FIXME: More functions will be needed later, but
       // it's enough for now.
     };

src/tgba/state.hh

@@ -63,7 +63,7 @@ namespace spot
   struct state_ptr_less_than
   {
     bool
-    operator()(const state* left, const state *right)
+    operator()(const state* left, const state *right) const
     {
       return left->compare(right) < 0;
     }

src/tgba/tgbaproduct.cc

@@ -1,6 +1,7 @@
 #include "tgbaproduct.hh"
 #include "tgbatranslateproxy.hh"
 #include "dictunion.hh"
+#include <string>
 #include <cassert>
 
 namespace spot