ltlcross: adjust to work with generic acceptance

* src/bin/ltlcross.cc: Remove Fin-acceptance before
doing checks.  More --verbose output.
* src/tgba/acc.cc, src/tgba/acc.hh: Add an eval_sets() function
to find the set of acceptance sets needed to satisfy the condition
in an accepting SCC.
* src/tgbaalgos/gtec/ce.cc: Use eval_sets() when computing
a counter example.
* src/tgbaalgos/gtec/gtec.cc: Raise an exception when called
on an acceptance that contains Fin.
* src/tgbatest/ltl2dstar3.test, src/tgbatest/ltlcrossce2.test:
New files.
* src/tgbatest/Makefile.am: Add them.
* src/tgba/tgba.cc (is_empty): Call remove_fin if needed.
* src/tgbaalgos/product.cc, src/tgbaalgos/dtgbacomp.cc: Adjust
to work with generic acceptance.

src/tgbatest/Makefile.am

@@ -109,6 +109,7 @@ TESTS = \
   ltlcross4.test \
   ltl2dstar.test \
   ltl2dstar2.test \
+  ltl2dstar3.test \
   ltl2ta.test \
   ltl2ta2.test \
   randaut.test \
@@ -121,6 +122,7 @@ TESTS = \
   emptchke.test \
   dfs.test \
   ltlcrossce.test \
+  ltlcrossce2.test \
   emptchkr.test \
   ltlcounter.test \
   basimul.test \

src/tgbatest/ltl2dstar3.test

@@ -0,0 +1,48 @@
+#!/bin/sh
+# -*- coding: utf-8 -*-
+# Copyright (C) 2015 Laboratoire de Recherche et
+# Développement de l'Epita (LRDE).
+#
+# This file is part of Spot, a model checking library.
+#
+# Spot is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Spot is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+# or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
+# License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Test ltl2dstar's HOA output with ltlcross.
+
+. ./defs
+set -e
+
+# Skip this test if ltl2dstar is not installed.
+(ltl2dstar --version) || exit 77
+
+ltlfilt=../../bin/ltlfilt
+ltl2tgba=../../bin/ltl2tgba
+ltlcross=../../bin/ltlcross
+randltl=../../bin/randltl
+ltlfilt=../../bin/ltlfilt
+dstar2tgba=../../bin/dstar2tgba
+
+RAB='--automata=rabin --output-format=hoa'
+STR='--automata=streett --output-format=hoa'
+
+# Run ltlcross without product, because this requires too much memory.
+$randltl -n 25 a b | $ltlfilt --remove-wm |
+$ltlcross -F- -f 'GFa & GFb & GFc' -f '(GFa -> GFb) & (GFc -> GFd)' \
+--timeout=30 --verbose --csv=out.csv --products=0 \
+"$ltl2tgba -s %f >%N" \
+"ltl2dstar $RAB --ltl2nba=spin:$ltl2tgba@-s %L %H" \
+"ltl2dstar $STR --ltl2nba=spin:$ltl2tgba@-s %L %H"
+
+grep '"in_type"' out.csv && exit 1
+exit 0

src/tgbatest/ltlcrossce2.test

@@ -0,0 +1,72 @@
+#!/bin/sh
+# -*- coding: utf-8 -*-
+# Copyright (C) 2015 Laboratoire de Recherche et
+# Développement de l'Epita (LRDE).
+#
+# This file is part of Spot, a model checking library.
+#
+# Spot is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Spot is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+# or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
+# License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+. ./defs
+set -e
+
+ltl2tgba=../../bin/ltl2tgba
+
+cat >fake <<\EOF
+#!/bin/sh
+case $1 in
+"U G e p0 F p1 p2")
+
+# echo 'U G e p0 F p1 p2' | ltl2dstar --output-format=hoa - - | fmt
+cat <<\END
+HOA: v1 States: 14 properties: implicit-labels trans-labels
+no-univ-branch deterministic complete acc-name: Rabin 3 Acceptance: 6
+(Fin(0)&Inf(1))|(Fin(2)&Inf(3))|(Fin(4)&Inf(5)) Start: 10 AP: 3 "p0"
+"p1" "p2" --BODY-- State: 0 {5} 0 3 5 5 0 3 5 5 State: 1 {3 4} 0 12 5
+1 0 12 5 1 State: 2 {3 4} 2 13 5 5 2 13 5 5 State: 3 {3 4} 13 13 5 5 13
+13 5 5 State: 4 {1 2 4} 4 4 4 4 4 4 4 4 State: 5 {0 2 4} 5 5 5 5 5 5 5
+5 State: 6 {2 4} 8 6 5 1 8 6 5 1 State: 7 {2 4} 7 8 5 5 2 8 5 5 State:
+8 {2 4} 8 8 5 5 8 8 5 5 State: 9 {2 4} 7 11 5 9 2 6 5 1 State: 10 {2 4}
+7 11 5 9 4 4 4 4 State: 11 {2 4} 8 11 5 9 8 6 5 1 State: 12 {4} 13 12
+5 1 13 12 5 1 State: 13 {4} 13 13 5 5 13 13 5 5 --END--
+END
+;;
+"! U G e p0 F p1 p2")
+# echo '! U G e p0 F p1 p2' | ltl2dstar --output-format=hoa - - | fmt |
+# sed '$s:8 13:13 8 /*<-bug*/:';
+cat <<\END
+HOA: v1 States: 14 properties: implicit-labels trans-labels
+no-univ-branch deterministic complete acc-name: Rabin 3 Acceptance: 6
+(Fin(0)&Inf(1))|(Fin(2)&Inf(3))|(Fin(4)&Inf(5)) Start: 11 AP: 3 "p0" "p1"
+"p2" --BODY-- State: 0 {5} 4 0 8 8 4 0 8 8 State: 1 {3 4} 1 1 8 8 1 1 8
+8 State: 2 {3 4} 1 2 8 13 1 2 8 13 State: 3 {3 4} 5 3 8 8 4 0 8 8 State:
+4 {1 2 4} 1 1 8 8 1 1 8 8 State: 5 {1 2 4} 5 3 8 8 1 1 8 8 State: 6 {1
+2 4} 6 3 8 8 12 1 8 8 State: 7 {1 2 4} 5 7 8 9 1 2 8 13 State: 8 {1 2 4}
+8 8 8 8 8 8 8 8 State: 9 {1 2 4} 6 7 8 9 12 2 8 13 State: 10 {0 2 4} 10
+10 10 10 10 10 10 10 State: 11 {2 4} 6 7 8 9 10 10 10 10 State: 12 {2 4}
+12 1 8 8 12 1 8 8 State: 13 {2 4} 12 2 13 8 /*<-bug*/ 12 2 8 13 --END--
+END
+;;
+esac
+EOF
+chmod +x fake
+
+run 1 ../../bin/ltlcross -f 'G(a <-> Fb) U c' \
+  "$ltl2tgba --lbtt %f >%T" "./fake %l >%T" 2> errors
+cat errors
+grep 'error: P0\*N1 is nonempty' errors
+grep 'error: P1\*N1 is nonempty' errors
+grep 'error: Comp..1.\*Comp..1. is nonempty' errors
+test `grep cycle errors | wc -l` = 3
+test `grep '^error:' errors | wc -l` = 4