* iface/gspn/gspn.cc, src/ltlvisit/basicreduce.cc,
src/ltlvisit/destroy.cc, src/ltlvisit/dotty.cc,
src/ltlvisit/dump.cc, src/ltlvisit/length.cc,
src/ltlvisit/nenoform.cc, src/ltlvisit/reduce.cc,
src/ltlvisit/syntimpl.cc, src/ltlvisit/tostring.cc,
src/tgba/formula2bdd.cc, src/tgba/tgbabddconcreteproduct.cc,
src/tgba/tgbatba.cc, src/tgbaalgos/dotty.cc,
src/tgbaalgos/dupexp.cc, src/tgbaalgos/lbtt.cc,
src/tgbaalgos/ltl2tgba_lacim.cc, src/tgbaalgos/neverclaim.cc,
src/tgbaalgos/save.cc, src/tgbaalgos/stats.cc,
src/tgbaalgos/gtec/nsheap.cc, src/tgbaalgos/gtec/nsheap.hh:
Declare private classes and helper function in anonymous namespaces.
* HACKING, src/sanity/style.test: Document and check this.
Also check for trailing { after namespace or class.
* src/ltlast/predecl.hh, src/ltlast/visitor.hh,
src/tgba/tgbareduc.hh: Fix trailing {.
This commit is contained in:
parent
5176caf4d2
commit
7d27fd3796
28 changed files with 3128 additions and 3025 deletions
6
HACKING
6
HACKING
|
|
@ -249,3 +249,9 @@ Other style recommandations
|
|||
Prefer <iosfwd> when predeclarations are sufficient, and then
|
||||
use for instance use just <ostream> in the corresponding .cc file.
|
||||
(A plain <iostream> is needed when using std::cout, std::cerr, etc.)
|
||||
|
||||
* Always declare helper functions and other local class definitions
|
||||
(used in a single .cc files) in anonymous namespaces. (The risk
|
||||
otherwise is to declare two classes with the same name: the linker
|
||||
will ignore one of the two silently. The resulting bugs are often
|
||||
difficult to understand.)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue