alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

* src/sanity/style.test: Suggest using "x->y", not "(*x).y".

Browse source 
* src/tgbaalgos/tarjan_on_fly.cc: Fix.
This commit is contained in:
Alexandre Duret-Lutz 2004-09-27 14:57:37 +00:00
parent 2c0a2cd517
commit 8b3bfaacdb
3 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2004-09-27 Alexandre Duret-Lutz <adl@src.lip6.fr>
* src/sanity/style.test: Suggest using "x->y", not "(*x).y".
* src/tgbaalgos/tarjan_on_fly.cc: Fix.
2004-09-23 Alexandre Duret-Lutz <adl@src.lip6.fr> 2004-09-23 Alexandre Duret-Lutz <adl@src.lip6.fr>
* src/sanity/style.test: Suggest ++i over i++ when it does not * src/sanity/style.test: Suggest ++i over i++ when it does not

3
src/sanity/style.test
View file

@ -125,6 +125,9 @@ for dir in "${INCDIR-..}" "${INCDIR-..}"/../iface; do
egrep '^[^=]*([+][+]|--);' $tmp && egrep '^[^=]*([+][+]|--);' $tmp &&
diag 'Take good habits: use ++i instead of i++ when you have the choice.' diag 'Take good habits: use ++i instead of i++ when you have the choice.'
grep '[^a-zA-Z0-9_](\*[a-zA-Z0-9_]*)\.' $tmp &&
diag 'Use "x->y", not "(*x).y"'
case $file in case $file in
*.hh | *.hxx) *.hh | *.hxx)
if egrep '(cout|cerr|clog)' $tmp >/dev/null; then if egrep '(cout|cerr|clog)' $tmp >/dev/null; then

18
src/tgbaalgos/tarjan_on_fly.cc
View file

@ -35,13 +35,11 @@ namespace spot
for (stack_type::iterator i = stack.begin(); for (stack_type::iterator i = stack.begin();
i != stack.end(); ++i) i != stack.end(); ++i)
{ {
//if ((*i).s)
hash_type::iterator hi = h.find(i->s); hash_type::iterator hi = h.find(i->s);
if (hi != h.end()) if (hi != h.end())
h.erase(hi); h.erase(hi);
delete (*i).s; delete i->s;
//if ((*i).lasttr) delete i->lasttr;
delete (*i).lasttr;
} }
for (hash_type::iterator i = h.begin(); for (hash_type::iterator i = h.begin();
@ -195,7 +193,7 @@ namespace spot
stack_type::const_iterator i; stack_type::const_iterator i;
for (i = stack.begin(); i != stack.end(); ++i, ++n) for (i = stack.begin(); i != stack.end(); ++i, ++n)
if (s->compare((*i).s) == 0) if (s->compare(i->s) == 0)
break; break;
if (i == stack.end()) if (i == stack.end())
@ -212,17 +210,17 @@ namespace spot
stack_type::iterator i; stack_type::iterator i;
for (i = stack.begin(); i != stack.end(); ++i) for (i = stack.begin(); i != stack.end(); ++i)
{ {
if (x && x->compare((*i).s) == 0) if (x && x->compare(i->s) == 0)
break; break;
ce->prefix.push_back(ce::state_ce((*i).s->clone(), ce->prefix.push_back(ce::state_ce(i->s->clone(),
(*i).lasttr->current_condition())); i->lasttr->current_condition()));
} }
for (; i != stack.end(); ++i) for (; i != stack.end(); ++i)
{ {
ce->cycle.push_back(ce::state_ce((*i).s->clone(), ce->cycle.push_back(ce::state_ce(i->s->clone(),
(*i).lasttr->current_condition())); i->lasttr->current_condition()));
} }
return ce; return ce;