alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

sanity: fix race conditions in the test suite

Browse source 
* tests/sanity/80columns.test, tests/sanity/includes.test,
tests/sanity/private.test, tests/sanity/style.test: Have each test
record failure in a separate file.
This commit is contained in:
Alexandre Duret-Lutz 2016-02-16 17:29:06 +01:00
parent 3a3913cf50
commit 9b5a763538
4 changed files with 22 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/sanity/style.test
View file

@ -32,7 +32,7 @@ diag()
echo ============================================================
}
rm -f failures
rm -f failures.style
GREP=grep
@ -324,7 +324,7 @@ for dir in "$TOP/spot" "$TOP/bin" "$TOP/tests"; do
esac
$fail && echo "$file" >>failures
$fail && echo "$file" >>failures.style
done || : # Make sure sh does not abort when read exits with false.
done
@ -346,14 +346,14 @@ for dir in "${INCDIR-..}" "${INCDIR-..}/../bin" "${INCDIR-..}/../tests"; do
$GREP '\.libs/' $tmp &&
diag "Don't reference files in .libs/, use Libtool instead."
$fail && echo "$file" >>failures
$fail && echo "$file" >>failures.style
done || : # Make sure sh does not abort when read exits with false.
done
if test -f failures; then
if test -f failures.style; then
echo "The following files contain style errors:"
cat failures
rm failures
cat failures.style
rm failures.style
exit 1;
fi