alarsyo/spot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

is_unambiguous: fix detection of empty languages

Browse source 
* src/tests/unambig.test: New test case.  Reported by Ming-Hsien Tsai.
* src/twaalgos/sccfilter.cc: Always create an initial state.
* src/twaalgos/isunamb.cc: Speed up on empty languages.
* NEWS, THANKS: Update.
This commit is contained in:
Alexandre Duret-Lutz 2015-10-20 08:06:31 +02:00
parent 61bf5daab4
commit cd8e53de09
5 changed files with 29 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
NEWS
View file

@ -65,6 +65,8 @@ New in spot 1.99.4a (not yet released)
* "ltlgrind -F FILENAME/COL" did not preserve other CSV columns. * "ltlgrind -F FILENAME/COL" did not preserve other CSV columns.
* "ltlgrind --help" did not document FORMAT. * "ltlgrind --help" did not document FORMAT.
* unabbreviate could easily use forbidden operators. * unabbreviate could easily use forbidden operators.
* "autfilt --is-unambiguous" could fail to detect the nonambiguity
of some automata with empty languages.
New in spot 1.99.4 (2015-10-01) New in spot 1.99.4 (2015-10-01)

1
THANKS
View file

@ -21,6 +21,7 @@ Kristin Y. Rozier
Martin Dieguez Lodeiro Martin Dieguez Lodeiro
Michael Tautschnig Michael Tautschnig
Michael Weber Michael Weber
Ming-Hsien Tsai
Nikos Gorogiannis Nikos Gorogiannis
Rüdiger Ehlers Rüdiger Ehlers
Silien Hong Silien Hong

20
src/tests/unambig.test
View file

@ -153,4 +153,22 @@ test `grep -c unambiguous output` = 0
../../bin/randltl --psl -n 1000 3 | $ltl2tgba -U -F- -H | ../../bin/randltl --psl -n 1000 3 | $ltl2tgba -U -F- -H |
$autfilt -v --is-unamb --stats=%M && exit 1 $autfilt -v --is-unamb --stats=%M && exit 1
: cat >input <<EOF
HOA: v1
properties: explicit-labels state-acc trans-labels
States: 3
Start: 0
AP: 0
Acceptance: 1 Inf(0)
acc-name: Buchi
name: ""
tool: "GOAL" ""
--BODY--
State: 0
[t] 2
[t] 1
State: 1
State: 2
--END--
EOF
run 0 $autfilt -q --is-unambiguous input

2
src/twaalgos/isunamb.cc
View file

@ -30,6 +30,8 @@ namespace spot
if (aut->is_deterministic() || aut->is_unambiguous()) if (aut->is_deterministic() || aut->is_unambiguous())
return true; return true;
auto clean_a = scc_filter_states(aut); auto clean_a = scc_filter_states(aut);
if (clean_a->num_edges() == 0)
return true;
auto prod = product(clean_a, clean_a); auto prod = product(clean_a, clean_a);
auto clean_p = scc_filter_states(prod); auto clean_p = scc_filter_states(prod);
return clean_a->num_states() == clean_p->num_states() return clean_a->num_states() == clean_p->num_states()

9
src/twaalgos/sccfilter.cc
View file

@ -324,11 +324,12 @@ namespace spot
} }
if (!given_si) if (!given_si)
delete si; delete si;
// If the initial state has been filtered out, we don't attempt // If the initial state has been filtered out, we have to create
// to fix it. // a new one (not doing so may cause empty automata, which in turn
// cause all sort of issue with algorithms assuming an automaton
// has one initial state).
auto init = inout[aut->get_init_state_number()]; auto init = inout[aut->get_init_state_number()];
if (init < out_n) filtered->set_init_state(init < out_n ? init : filtered->new_state());
filtered->set_init_state(init);
return filtered; return filtered;
} }