Commit graph

1099 commits

Author SHA1 Message Date
Etienne Renault
b115d2f9b1 fixpool: remove useless clz encapsulation
* spot/misc/fixpool.hh: Here.
2020-06-03 12:22:40 +02:00
Etienne Renault
4871635159 bloemen: fix memory leaks
* spot/mc/bloemen.hh, spot/mc/mc.hh: here.
2020-06-03 12:22:40 +02:00
Etienne Renault
2dd2d44907 deadlock: fix memory leak
Do not forget to recycle iterator, otherwise the todo
stack will be trashed without cleaning iterators.

* spot/mc/deadlock.hh: Here.
2020-06-03 12:22:40 +02:00
Etienne Renault
23edf52dd5 fixpool: propose alternative policy
In 3fe74f1c, fixed_size_pool was changed in order to
help memcheck to detect "potential" memory leaks. In a
multithreaded context, this could raise false alarm. To
solve this, we proprose 2 policies for the pool, one with
the check and one without.

* spot/misc/fixpool.cc: deleted ...
* spot/ltsmin/ltsmin.cc, spot/ltsmin/spins_kripke.hh,
spot/mc/deadlock.hh, spot/misc/Makefile.am,
spot/misc/fixpool.cc, spot/misc/fixpool.hh,
spot/priv/allocator.hh, spot/ta/tgtaproduct.cc,
spot/ta/tgtaproduct.hh, spot/twa/twaproduct.cc,
spot/twa/twaproduct.hh, tests/core/mempool.cc: Here.
2020-06-03 12:22:26 +02:00
Etienne Renault
5d30286dd6 twacube: 'mark_t' is deprecated
* spot/mc/ec.hh, spot/mc/intersect.hh,
tests/core/twacube.cc: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
73ccf2216d bloemen: avoid tail-recursive calls
* spot/mc/bloemen.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
ae101a509f bloemen: PPOPP'16 is buggy
In PPOPP'16, the algorithm does not unlock
roots. This could lead to deadlock between
threads.

* spot/mc/bloemen.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
2bd08d956a mc: please Werror=noexcept
* spot/mc/intersect.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
011115cb1d tests: include missing config.h
* spot/mc/unionfind.cc,
spot/twacube/cube.cc,
spot/twacube/twacube.cc,
spot/twacube_algos/convert.cc,
tests/core/bricks.cc,
tests/core/cube.cc,
tests/core/twacube.cc: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
f777e96890 mc: recycle iterators in bloemen
* spot/mc/bloemen.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
63a4b4085a mc: bloemen count unique states
* spot/mc/bloemen.hh, tests/ltsmin/modelcheck.cc: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
0b917af762 mc: please sanity.test
* spot/mc/bloemen.hh, spot/mc/mc.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
e6e3b568ca mc: parallel version of bloemen
* spot/mc/bloemen.hh,
tests/ltsmin/modelcheck.cc: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
01093f992e mc: sequential version of Bloemen
* spot/mc/Makefile.am, spot/mc/bloemen.hh,
spot/mc/mc.hh, tests/ltsmin/modelcheck.cc: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
15e72e90cc mc: add swarmed deadlock-detection
* spot/mc/Makefile.am, spot/mc/deadlock.hh,
spot/mc/mc.hh, tests/ltsmin/modelcheck.cc: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
f486dab241 ltsmin: move modelchek in mc directory
* spot/ltsmin/ltsmin.cc, spot/ltsmin/ltsmin.hh,
spot/mc/Makefile.am, tests/ltsmin/modelcheck.cc,
spot/mc/mc.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
1d4cb26235 ltsmin: remove shared table at model level
Experiments shows  that this table slows down algorithms
since the management is also tracked at higher lever by
algorithms

* spot/ltsmin/spins_kripke.hh,
spot/ltsmin/spins_kripke.hxx: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
f9b0044623 ltsmin: please private.test
* spot/ltsmin/Makefile.am, spot/ltsmin/spins_interface.hh: here.
* spot/ltsmin/spins_interface.cc: delete.
2020-06-03 10:33:54 +02:00
Etienne Renault
32b79818dc kripke: avoir internal compiler error
gcc snapshot yield internal compiler error: tree check: accessed elt 2
of tree_vec with 1 elts in tsubst, at cp/pt.c:13693

* spot/kripke/kripke.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
7bac705e83 twacube: please gcc null-dereference
* spot/twacube/twacube.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
b8258ac638 twacube: move useless unsigned int to unsigned
* spot/twacube/twacube.cc,
spot/twacube/twacube.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
cb343ff02d twacube: more documentation
* spot/twacube/twacube.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
fbf9d98e15 Fix typo
* spot/mc/ec.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
d95428d245 ltsmin: remove ltdl from public headers
* spot/ltsmin/Makefile.am,
spot/ltsmin/spins_interface.cc,
spot/ltsmin/spins_interface.hh: here.
2020-06-03 10:33:54 +02:00
Etienne Renault
941608060e ltsmin: fix call to destructor
* spot/ltsmin/spins_kripke.hxx: here
2020-06-03 10:33:53 +02:00
Etienne Renault
3c868c228b ltsmin: do not take iterators by copy
* spot/ltsmin/spins_kripke.hxx: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
df872ce6d9 ltsmin: placement new requires placement delete
This commit fixes a bug that (randomly) occurs when
calling destructor of kripkecube.

*  spot/ltsmin/spins_kripke.hxx: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
0be3630218 ltsmin: extract kripkecube to ease manipulation
* spot/ltsmin/Makefile.am,
spot/ltsmin/ltsmin.cc,
spot/ltsmin/ltsmin.hh
spot/ltsmin/spins_kripke.hh,
spot/ltsmin/spins_kripke.hxx: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
5445007070 ltsmin: extract spins interface
* spot/ltsmin/Makefile.am, spot/ltsmin/ltsmin.cc,
spot/ltsmin/ltsmin.hh,
spot/ltsmin/spins_interface.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
8a930c7572 ltsmin: simplify iterator
* spot/ltsmin/ltsmin.cc: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
03ff789324 mark_t::operator bool() is now explicit
Follows up cf5d2c2b.

* spot/mc/ec.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
6d282bbc6b ltsmin: update usage of brick-hashset
From a discussion with Petr Rockai: "the possibly non-intuitive bit
that you probably didn't notice is that the hashset is supposed to be
passed to each thread by value. The copy semantics of the entire
hashset are that of a shared pointer: multiple copies share the same
underlying data. Each thread *must* have its own private copy of the
hashset object (there are bits of state that each thread needs for
bookkeeping and those must not be shared)."

*  spot/ltsmin/ltsmin.cc: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
606e4fc88c please pedantic option for gcc
* spot/kripke/kripke.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
bb9fa4e910 bricks: update and move to c++14
* Makefile.am, bricks/brick-assert,
bricks/brick-assert.h, spot/ltsmin/ltsmin.cc,
spot/mc/ec.hh: here.

* bricks/brick-bitlevel.h, bricks/brick-hash.h,
bricks/brick-hashset.h, bricks/brick-shmem.h,
bricks/brick-types.h: Rename as ...
* bricks/brick-bitlevel, bricks/brick-hash,
bricks/brick-hashset, bricks/brick-shmem,
bricks/brick-types: ... these
2020-06-03 10:33:53 +02:00
Etienne Renault
9208726d97 reachability: improve support for callbacks
* spot/mc/reachability.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
72948661e9 swarming: add support everywhere
Swarming implies that a single instance of the kripke
structure (or product) will be explored by diffrent threads
with their own exploration order. Most of the modification
aims to have a thread safe kripke structure.

* spot/kripke/kripke.hh, spot/ltsmin/ltsmin.cc,
spot/ltsmin/ltsmin.hh, spot/mc/ec.hh,
spot/mc/intersect.hh, spot/mc/reachability.hh,
spot/misc/hash.hh, spot/twacube/twacube.hh,
tests/core/twacube.test, tests/ltsmin/modelcheck.cc: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
fb4ef40d11 Use SPOT_ASSERT() instead of assert() in public headers
* spot/mc/ec.hh, spot/mc/intersect.hh,
spot/mc/reachability.hh, spot/mc/utils.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
50d888adf8 Twacube must share the order of atomic propositions
* spot/ltsmin/ltsmin.cc, spot/ltsmin/ltsmin.hh,
tests/ltsmin/modelcheck.cc: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
9a9a237272 timer: support for walltime
* spot/misc/timer.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
765bb8a7c4 Promote use of shared_ptr
* spot/kripke/kripke.hh, spot/ltsmin/ltsmin.cc,
spot/ltsmin/ltsmin.hh, spot/mc/ec.hh, spot/mc/intersect.hh,
spot/mc/utils.hh, spot/twacube/Makefile.am,
spot/twacube/fwd.hh, spot/twacube/twacube.hh,
spot/twacube_algos/convert.cc, spot/twacube_algos/convert.hh,
tests/core/twacube.cc, tests/ltsmin/modelcheck.cc: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
7d2abe229b swig: prefer typedef to using
According to swig3.0. the 'using' keyword
in type aliasing is not fully supported yet.

* spot/ltsmin/ltsmin.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
9799f2884e modelcheck: support for twacube
* spot/ltsmin/ltsmin.cc, spot/ltsmin/ltsmin.hh,
tests/ltsmin/modelcheck.cc: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
94f7c58f44 intersect: statistic provided using an object
* spot/mc/ec.hh, spot/mc/intersect.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
d430129bb1 convert: simplify interfaces
* spot/twacube_algos/convert.cc, spot/twacube_algos/convert.hh,
tests/core/twacube.cc: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
e11f24dbc1 twacube: atomic propositions are now passed by copy
Passing atomic propositions by reference allows to
save very little memory so it doesn't worth complexifying
memory management.

* spot/twacube/twacube.cc, spot/twacube/twacube.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
f04074bd6d sanity: replace tabulars by spaces
* spot/ltsmin/ltsmin.cc,
spot/mc/ec.hh, spot/mc/intersect.hh,
spot/mc/reachability.hh, spot/mc/unionfind.cc,
spot/mc/utils.hh, spot/twacube/cube.cc,
spot/twacube/twacube.cc,
spot/twacube/twacube.hh,
spot/twacube_algos/convert.cc,
spot/twacube_algos/convert.hh,
tests/core/bricks.cc,
tests/core/cube.cc,
tests/core/twacube.cc,
tests/ltsmin/modelcheck.cc: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
681c2b2011 ltsmin: use FastConcurrent map
* spot/ltsmin/ltsmin.cc: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
b4bbf50794 ltsmin: prodcuce kripkecube
Warning! this patch introduces redundancy (or difference)
between wether you ask for a kripkecube or a kripke.

* spot/ltsmin/ltsmin.cc, spot/ltsmin/ltsmin.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
8e593611f6 convert: kripke and product towards twa
* spot/mc/Makefile.am, spot/mc/utils.hh: here.
2020-06-03 10:33:53 +02:00
Etienne Renault
3bafe693ef ec: Renault et al LPAR'13 emptiness check
In order to reuse the computation of the
intersection between kripke and twa efficiently,
we use template inheritance through the
"mixin templates" technique.

* spot/Makefile.am, spot/mc/Makefile.am,
spot/mc/ec.hh, spot/mc/unionfind.cc,
spot/mc/unionfind.hh: here.
2020-06-03 10:33:53 +02:00